[sudo-commits] sudo changeset 14710:745430b563db

Todd C. Miller Todd.Miller at sudo.ws
Wed Apr 19 14:41:49 MDT 2023


changeset:	14710:745430b563db in /raid/repos/sudo
details:	https://www.sudo.ws/repos/sudo/rev/745430b563db
user:		Todd C. Miller <Todd.Miller at sudo.ws>
date:		Tue Apr 18 13:52:26 2023 -0600

Log Message:
	Avoid calling isatty()/ttyname() on std{in,out,err} if not a char dev.

	The user controls these fds so we should avoid calling ioctl(2) on
	them unless they correspond to actual character device files.

diffstat:

 src/exec_nopty.c |   7 +++--
 src/exec_pty.c   |  13 ++++++-----
 src/selinux.c    |   2 +-
 src/sudo.h       |   1 +
 src/ttyname.c    |  62 +++++++++++++++++++++++++++++++++++++++++--------------
 5 files changed, 59 insertions(+), 26 deletions(-)



More information about the sudo-commits mailing list