From dkopecek at redhat.com Thu Oct 30 10:02:58 2008 From: dkopecek at redhat.com (Daniel =?UTF-8?B?S29wZcSNZWs=?=) Date: Thu, 30 Oct 2008 14:02:58 +0000 Subject: [sudo-workers] sudo -l segfaults Message-ID: <20081030140258.297845b7@dhcp-lab-189.englab.brq.redhat.com> Hi, we've got recently a bug report against sudo. Patch for this bug is attached to this mail. I've attached two versions of this patch because there is an older version in F-9 (1.6.9p13) and the patch for this version modifies sudo.tab.c also. I've tested the latest stable version (1.6.9p17) and it segfaults too. The second patch modifies only parse.yacc but then the sudo.tab.c needs to be regenerated. Please review this patch. For details see https://bugzilla.redhat.com/show_bug.cgi?id=466292. Thanks, Dan -------------- next part -------------- A non-text attachment was scrubbed... Name: sudo-1.6.9p13-selinuxfix.patch Type: text/x-patch Size: 25316 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: parse_yacc.patch Type: text/x-patch Size: 2535 bytes Desc: not available URL: From dkopecek at redhat.com Thu Oct 30 11:24:52 2008 From: dkopecek at redhat.com (Daniel =?UTF-8?B?S29wZcSNZWs=?=) Date: Thu, 30 Oct 2008 15:24:52 +0000 Subject: [sudo-workers] sudo -l segfaults Message-ID: <20081030152452.5601d0bc@dhcp-lab-189.englab.brq.redhat.com> Hi, we've got recently a bug report against sudo. Patch for this bug is attached to this mail. I've attached two versions of this patch because there is an older version in F-9 (1.6.9p13) and the patch for this version modifies sudo.tab.c also. I've tested the latest stable version (1.6.9p17) and it segfaults too. The second patch modifies only parse.yacc but then the sudo.tab.c needs to be regenerated. Please review this patch. For details see https://bugzilla.redhat.com/show_bug.cgi?id=466292. Thanks, Dan -------------- next part -------------- A non-text attachment was scrubbed... Name: sudo-1.6.9p13-selinuxfix.patch Type: text/x-patch Size: 25316 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: parse_yacc.patch Type: text/x-patch Size: 2535 bytes Desc: not available URL: From Todd.Miller at courtesan.com Thu Oct 30 10:25:12 2008 From: Todd.Miller at courtesan.com (Todd C. Miller) Date: Thu, 30 Oct 2008 10:25:12 -0400 Subject: [sudo-workers] sudo -l segfaults In-Reply-To: Your message of "Thu, 30 Oct 2008 14:02:58 -0000." <20081030140258.297845b7@dhcp-lab-189.englab.brq.redhat.com> References: <20081030140258.297845b7@dhcp-lab-189.englab.brq.redhat.com> Message-ID: <200810301425.m9UEPCD7009539@core.courtesan.com> Thanks for the patch, that will go in 1.6.9p18. - todd From Todd.Miller at courtesan.com Thu Oct 30 10:37:22 2008 From: Todd.Miller at courtesan.com (Todd C. Miller) Date: Thu, 30 Oct 2008 10:37:22 -0400 Subject: [sudo-workers] sudo -l segfaults In-Reply-To: Your message of "Thu, 30 Oct 2008 15:24:52 -0000." <20081030152452.5601d0bc@dhcp-lab-189.englab.brq.redhat.com> References: <20081030152452.5601d0bc@dhcp-lab-189.englab.brq.redhat.com> Message-ID: <200810301437.m9UEbMbQ014918@core.courtesan.com> In message <20081030152452.5601d0bc at dhcp-lab-189.englab.brq.redhat.com> so spake Daniel =?UTF-8?B?S29wZcSNZWs=?= (dkopecek): > diff -up sudo-1.6.9p13/parse.yacc.orig sudo-1.6.9p13/parse.yacc > --- sudo-1.6.9p13/parse.yacc.orig 2008-10-30 14:07:52.000000000 +0100 > +++ sudo-1.6.9p13/parse.yacc 2008-10-30 14:06:58.000000000 +0100 > @@ -569,6 +569,7 @@ selinux : /* empty */ { > #ifdef HAVE_SELINUX > if (printmatches == TRUE && host_matches == TRUE && > user_matches == TRUE && runas_matches == TRUE) > { > + if (match[top-1].role != NULL) { > /* Inherit role. */ > cm_list[cm_list_len].role = > estrdup(cm_list[cm_list_len-1].role); > @@ -576,6 +577,12 @@ selinux : /* empty */ { > cm_list[cm_list_len-1].role_len; > cm_list[cm_list_len].role_size = > cm_list[cm_list_len-1].role_len + 1; > + } else { > + cm_list[cm_list_len].role = NULL; > + cm_list[cm_list_len].role_len = 0; > + cm_list[cm_list_len].role_size = 0; > + } > + if (match[top-1].type != NULL) { > /* Inherit type. */ > cm_list[cm_list_len].type = > estrdup(cm_list[cm_list_len-1].type); The part where you zero out role et al in the match[top-1].role == NULL case should not be required as that will already be zero. - todd From dkopecek at redhat.com Thu Oct 30 11:38:49 2008 From: dkopecek at redhat.com (Daniel Kopecek) Date: Thu, 30 Oct 2008 11:38:49 -0400 (EDT) Subject: [sudo-workers] sudo -l segfaults In-Reply-To: <200810301437.m9UEbMbQ014918@core.courtesan.com> Message-ID: <1889220320.745711225381129638.JavaMail.root@zmail02.collab.prod.int.phx2.redhat.com> ----- "Todd C. Miller" wrote: > In message > <20081030152452.5601d0bc at dhcp-lab-189.englab.brq.redhat.com> > The part where you zero out role et al in the match[top-1].role == > > NULL case should not be required as that will already be zero. > > > > - todd Ok. Thanks. Dan From paulmacleod7 at hotmail.com Thu Oct 30 07:56:58 2008 From: paulmacleod7 at hotmail.com (Paul MacLeod) Date: Thu, 30 Oct 2008 11:56:58 +0000 Subject: [sudo-workers] sudo 1.7 - stable? Message-ID: Hi Guys, I can see on the main page that the stable release has been 1.6.9p17 since June 26th, and the development 1.7.0rc2 since June 10th. Been checking frequently with no changes. There hasn't been many mails to 'workers' and so I'm wondering when things will be considered good for 1.7 to become the stable release? Does anyone have thoughts, concerns about this or an idea of when this will happen? Thanks, -Paul. _________________________________________________________________ Make a mini you and download it into Windows Live Messenger http://clk.atdmt.com/UKM/go/111354029/direct/01/