[sudo-users] Problem with defaults (v1.7.0rc2)

Todd C. Miller Todd.Miller at courtesan.com
Sat Oct 25 09:21:42 EDT 2008


The following patch should fix this.

 - todd

Index: parse.c
===================================================================
RCS file: /home/cvs/courtesan/sudo/parse.c,v
retrieving revision 1.230
diff -u -r1.230 parse.c
--- parse.c	8 May 2008 21:54:09 -0000	1.230
+++ parse.c	25 Oct 2008 13:20:10 -0000
@@ -146,22 +146,22 @@
 		if (!set_default(def->var, def->val, def->op))
 		    return(FALSE);
 	    case DEFAULTS_USER:
-		if (userlist_matches(sudo_user.pw, &def->binding) &&
+		if (userlist_matches(sudo_user.pw, &def->binding) == ALLOW &&
 		    !set_default(def->var, def->val, def->op))
 		    return(FALSE);
 		break;
 	    case DEFAULTS_RUNAS:
-		if (runaslist_matches(&def->binding, NULL) &&
+		if (runaslist_matches(&def->binding, NULL) == ALLOW &&
 		    !set_default(def->var, def->val, def->op))
 		    return(FALSE);
 		break;
 	    case DEFAULTS_HOST:
-		if (hostlist_matches(&def->binding) &&
+		if (hostlist_matches(&def->binding) == ALLOW &&
 		    !set_default(def->var, def->val, def->op))
 		    return(FALSE);
 		break;
 	    case DEFAULTS_CMND:
-		if (cmndlist_matches(&def->binding) &&
+		if (cmndlist_matches(&def->binding) == ALLOW &&
 		    !set_default(def->var, def->val, def->op))
 		    return(FALSE);
 	}



More information about the sudo-users mailing list