[sudo-workers] uninits and strsplit problems

Todd C. Miller Todd.Miller at courtesan.com
Tue Aug 18 09:06:02 MDT 2015

On Tue, 18 Aug 2015 08:40:03 -0400, Radovan Sroka wrote:
Message-Id: <aea6d8afa56925d2 at courtesan.com>

> I've got another issue, it's not so important as previous but there are many 
> uninit problems around strsplit function so I looked at this issue and here's
>  my solution.
> I initialize "ep" variable to NULL before first call of sudo_strsplit in scop
> e and add exclusion condition into sudo_strsplit_v1. This patch resolves ever
> y warning around sudo_strsplit function.
Message-Id: <aea6d8b0af18a869 at courtesan.com>

These all look like false positives to me.  sudo_strsplit() is never
called with both str and *last NULL.  Also, ep is not used uninitialized
because it is always set by the first call to sudo_strsplit() when
str is not NULL.
Message-Id: <aea6d8b1226cce5f at courtesan.com>

 - todd

More information about the sudo-workers mailing list