[sudo-workers] visudo segfault

[Radovan Sroka]

Hi Todd,

there is a segfault in visudo when you want to appent to the list
in case like that:

Defaults    env_keep =  "COLORS DISPLAY HOSTNAME HISTSIZE KDEDIR LS_COLORS"
Defaults    env_keep += "MAIL PS1 PS2 QTDIR USERNAME LANG LC_ADDRESS LC_CTYPE"

BackTrace:

(gdb) bt
#0  __strncmp_sse42 () at ../sysdeps/x86_64/multiarch/strcmp-sse42.S:164
#1  0x0000555555564d6c in list_op (val=0x55555578eb30 "MAIL PS1 PS2 QTDIR USERNAME LANG LC_ADDRESS LC_CTYPE", len=4, def=0x7fffffffe0c0, op=add) at ./defaults.c:953
#2  0x0000555555564775 in store_list (str=0x55555578eb30 "MAIL PS1 PS2 QTDIR USERNAME LANG LC_ADDRESS LC_CTYPE", def=0x7fffffffe0c0, op=43) at ./defaults.c:850
#3  0x0000555555562bf1 in set_default_entry (def=0x7fffffffe0c0, val=0x55555578eb30 "MAIL PS1 PS2 QTDIR USERNAME LANG LC_ADDRESS LC_CTYPE", op=43, quiet=false, do_callback=false) at ./defaults.c:251
#4  0x0000555555564041 in check_defaults (what=31, quiet=false) at ./defaults.c:717
#5  0x000055555555bfd9 in reparse_sudoers (editor=0x55555578f190 "/bin/vi", editor_argc=4, editor_argv=0x55555578f1b0, strict=false, quiet=false) at ./visudo.c:593
#6  0x000055555555ab47 in main (argc=1, argv=0x7fffffffe2e8) at ./visudo.c:275

Version of sudo is 1.8.18b1.
---------------------------------------------------------

Radovan Sroka
Security Technologies | Red hat, Inc.