[sudo-workers] packaging versus make questions

[Michael Felt]

On 27/04/2017 00:01, Todd C. Miller wrote:

First of all - thanks. The updates look very nice. - re: /etc/rc.d on 
AIX - please see below.
> On Tue, 24 Jan 2017 13:20:40 +0100, Michael Felt wrote:
>
> I'm finally getting around to addressing these points, sorry for
> the long delay.
>
>> in sudo.pp I see the comment:
>>
>> %else
>>           # For all but RPM and Debian we need to install sudoers with a
>> different
>>           # name and make a copy of it if there is no existing file.
>>           mv ${pp_destdir}$sudoersdir/sudoers
>> ${pp_destdir}$sudoersdir/sudoers.dist
>>
>> Why not have 'make' create sudoers.dist as default, and both in make
>> install and sudo.pp
>> have the test to not overwrite ${pp_destdir}$sudoersdir/sudoers if it
>> already exists?
> I've made a change like this in:
>      https://www.sudo.ws/repos/sudo/rev/40f8e5806d71
>
>> For AIX, something similar for /etc/rc.d/rc2.s/S90sudo -i.e., do not
>> make it as a file (or link) when DESTDIR is defined,
>> but leave it as a comment. I notice that you do not package it using
>> sudo.pp - but do currently create it
>> when running make DESTDIR=/some/where/else install
> See https://www.sudo.ws/repos/sudo/rev/4200ef757b56
>
>> Small thing in sudo.pp:
>>
>> in the %post for AIX you have a test on /etc/rc.d - obviously, that
>> directory exists as you just installed /etc/rc.d/init.d/sudo.
>> The correct test is probably on the directory /etc/rc.d/rc2.d
> The intent was to avoid installing the link on AIX systems without
> /etc/rc.d since not all AIX systems have that.  Of course, since
> it just installed /etc/rc.d/init.d/sudo this check is not effective.
> I've modified it to check for /etc/rc.d/rc2.d instead which should
> be a little better.
FYI: afaik - since AIX 5.0 (the early adopters release in 1999-2000) 
/etc/rc.d exists as part of the "Linux Affinity" as well as "Solaris 
Affinity".

I forget if it was already in AIX 4.3.X. In any case, since at least 
2000 it has been a standard entry in /etc/inittab with entries such as:
root at x062:[/export/lpp]grep rc.d /etc/inittab
l2:2:wait:/etc/rc.d/rc 2
l3:3:wait:/etc/rc.d/rc 3
l4:4:wait:/etc/rc.d/rc 4
l5:5:wait:/etc/rc.d/rc 5
l6:6:wait:/etc/rc.d/rc 6
l7:7:wait:/etc/rc.d/rc 7
l8:8:wait:/etc/rc.d/rc 8
l9:9:wait:/etc/rc.d/rc 9

The directory /etc/rc.d/init.d is more recent - not sure when it became 
"default", but it seems to be standard now - with symbolic links from, 
e.g., rc2.d to init.d

>
>> p.s. the embedded zlib looks like it needs a facelift (the version
>> string I found is 1.2.8 while the latest version is (very recently)
>> updated to 1.2.10
> Thanks for mentioning this, sudo 1.8.20 will include zlib 1.2.11.
>
>   - todd